First version CoinosProvider interface #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emventures#8) * add public key in SignedMessage type * add Lint and Build in GH actions * Apply suggestions from code review Co-authored-by: Marco Argentieri <[email protected]>
* split index.js into several files + add DataRecipient type * modify AddressRecipient and DataRecipient
louisinger
changed the title
4 tasks
tiero
reviewed
Oct 28, 2021
|
Not sure if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CoinosProviderwill be injected into web pages by Marina extension. The idea is to provide methods in order to interact with the 2of2 (Marina+coinos) account.getNetwork,getNextAddressandgetNextChangeAddress,signTransaction,sendTransactionbehave like the marina provider. Note that the addresses in getNext*Address methods will use the multisig scripts (2of2 account).getCoins,getTransactionsandgetBalancesreturns data about coins owned by the 2of2 account, excluding all other coins owned by the marina main account.approveSpendreturns a PSET (base64 encoded) signed by the Marina user. It lets to create PSET with signed inputs using SIGHASH_NONE + SIGHASH_ANYONE_CAN_PAY and no outputs.getWalletInforeturns the xpub of Marina and the xpub used as cosigner (the coinos one).@asoltys @tiero please review