Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issue: existing_contact select widget fails to lock fields #1008

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

bsilvern
Copy link
Contributor

Overview

Locked fields are not actually locked when an existing_contact element is configured as a Select widget.

Before

Locked fields with an existing_contact Select widget were not actually locked.

After

  • Locked fields with an existing_contact Select widget are locked as demonstrated by ExistingContactElementTest::testNextPrevSaveLoad() line 640.
  • The test introduced in the previous PR in this series completes without error.

Technical Details

Comments

The tests are unchanged from the previous PR in this series.

@KarinG
Copy link
Collaborator

KarinG commented Nov 16, 2024

Jitendra approved - going to merge this now so that they will be in the next release.

@KarinG KarinG merged commit d76b6bf into colemanw:6.x Nov 16, 2024
2 of 4 checks passed
@KarinG
Copy link
Collaborator

KarinG commented Nov 17, 2024

Bob -> note we ended up skipping this test for D10.3+

https://github.com/colemanw/webform_civicrm/blob/6.x/tests/src/FunctionalJavascript/ExistingContactElementTest.php#L532-L536

Because in D10.3 we get:

$webform->get('elements') is { }

We tried a couple of things e.g.
$elements = $webform->getElementsDecodedAndFlattened();

But could not get it to work.

Also not directly related but relevant for future:
966x: The "yaml_parser_class" setting is deprecated in drupal:10.3.0. This setting should be removed from the settings file, since its usage has been removed. See https://www.drupal.org/node/3415489. which means Drupal\Core\Serialization\Yaml is deprecated.

@bsilvern
Copy link
Contributor Author

@KarinG OK, thanks. I'll update the test if I can find a way to support D10.3+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants