D9 - Replace group usage with crmgroup to avoid inconsistency with drupal #group #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrapurohit
changed the title
|
Can this be merged? |
|
@pradpnayak - are you able to add some comments here re: having tested this PR? Have your team had it in production? It's not a trivial change and involves and update hook. |
|
@jitendrapurohit - could you please resolve the conflict. I updated the hook_number but there are more conflicts. Also -> has Fuzion had this in production? |
jitendrapurohit
force-pushed
the
rename_group
branch
from
bc00777 to
ec38fd6
Compare
|
@adixon @pradpnayak @shaneonabike @MegaphoneJon - you have all shown interest in this PR at some point. I sponsored this PR as I it resolves a structural conflict, but since none of our Semper IT clients nor any of the Fuzion clients are actively using it, it could really use some real-life testing / confirmation by one (or all!) of you (incl. running the db update) - before we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Existing Contact can have validation error when filtered by group
Before
Existing Contact can have validation error when filtered by group
After
No error.
Technical Details
Implements the longer approach from #619 (comment)
Replace
groupusage withcrmgroupto avoid inconsistency with drupal#groupComments
Drupal Ticket: https://www.drupal.org/project/webform_civicrm/issues/3254254