Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] - D9/10 - Fix ordering on payment table #955

Open
wants to merge 4 commits into
base: 6.x
Choose a base branch
from

Conversation

jitendrapurohit
Copy link
Collaborator

Overview

Ensure Payment table lists the amount options according to the order set on the build page.

Before

If there are multiple payment options on the webform, there are several display issues with the payment table.

  • The list is not in the order of the build page.
  • If the line item elements are of type Radio or Checkbox, a default Contribution label is displayed instead of the label configured for the element.

Eg, the Element order on the build page for this webform is

  • Membership Fee
  • First Line Item Amount
  • Second Line Item Amount
  • Donation Amount.

But the payment table displays some random order with labels incorrect for checkbox and radio inputs.

Contact Information

After

Fixed.

  • Sorting is according to the labels set on the build page configuration.
  • Label is fixed to ensure its displayed as per the element config.
First Line Item Amount

@jitendrapurohit jitendrapurohit changed the title D9/10 - Fix ordering on payment table [wip] - D9/10 - Fix ordering on payment table Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant