Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D10 - Fix intermittent test failure with billing blocks #964

Open
wants to merge 2 commits into
base: 6.x
Choose a base branch
from

Conversation

jitendrapurohit
Copy link
Collaborator

@jitendrapurohit jitendrapurohit commented May 11, 2024

Overview

Fix iats test failure

Before

Fails https://github.com/colemanw/webform_civicrm/actions/runs/9020820999

Drupal\\Tests\\webform\_civicrm\\FunctionalJavascript\\ContributionIatsTest::testSubmitACHEFTContribution

[28](https://github.com/colemanw/webform_civicrm/actions/runs/9020820999/job/24800162518#step:24:29)
Behat\\Mink\\Exception\\ElementNotFoundException: 
Form field with id|name|label|value|placeholder "Account Holder" not found.

After

Pass

Technical Details

Add values to billing fields before filling iats fields, so it gets time to load.

Comments

@KarinG

@KarinG
Copy link
Collaborator

KarinG commented May 11, 2024

Ah different now:

1) Drupal\Tests\webform_civicrm\FunctionalJavascript\ContributionIatsTest::testSubmitACHEFTContribution
Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value|placeholder "Account No." not found.

Shane did some cleaning up/rewording here: iATSPayments/com.iatspayments.civicrm#429 - but that was some time ago (back in Fall 2023).

@jitendrapurohit
Copy link
Collaborator Author

acheft_iats

Screenshot indicates that the iATS element has not loaded yet. Hmm, even after waiting for 5 seconds! It loads almost instantly on local.

I might try updating it to 10 seconds.

@KarinG
Copy link
Collaborator

KarinG commented May 12, 2024

Hi - it's not the iATS element - it's the CiviCRM direct debit fields [with a little relabeling for terminology]. Note that they load fine... for all previous combinations of Drupal and CiviCRM.

@demeritcowboy
Copy link
Collaborator

@jitendrapurohit I'm pretty sure this is a smarty4 issue with iats 1.8.0 - see #965. It's fixed in iats master.
If you set \Civi::settings()->set('backtrace', 1); and have the network console open while you're watching the test there's a point where it has an error 500, and if you're quick enough or using xdebug/breakpoint you can see the smarty template compile error and backtrace in the response subtab.

@jitendrapurohit jitendrapurohit mentioned this pull request May 14, 2024
@jitendrapurohit jitendrapurohit changed the title D10 - Fix iats test failure D10 - Fix intermittent test failure with billing blocks May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants