D11 - WIP

[demeritcowboy]

Overview

A brief description of the pull request. Try to keep it non-technical.

Before

The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

After

What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

Anything else you would like the reviewer to note

[demeritcowboy]

Composer says:

drupal/webform 6.x-dev is an alias of drupal/webform dev-6.x and thus requires it to be installed too

Of course it does.
Anyway, seems there is no drupal 11-ready parent webform branch to work with yet. https://www.drupal.org/project/webform/issues/3446999 seems incomplete. Could try applying it and also an update to its composer.json and see what happens.

[demeritcowboy]

I don't really know what this means. It happens while the parent webform module is installed. Something missing from here maybe.

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for editor.editor.webform_default with the following errors: editor.editor.webform_default:settings.plugins.ckeditor5_list.reversed missing schema, editor.editor.webform_default:settings.plugins.ckeditor5_list.startIndex missing schema

/home/runner/drupal/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/home/runner/drupal/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/home/runner/drupal/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/home/runner/drupal/web/core/lib/Drupal/Core/Config/Config.php:230
/home/runner/drupal/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/home/runner/drupal/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/home/runner/drupal/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/home/runner/drupal/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/home/runner/drupal/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:613
/home/runner/drupal/web/modules/contrib/webform/includes/webform.install.inc:525
/home/runner/drupal/web/modules/contrib/webform/webform.install:38

[demeritcowboy]

Where this is at:

• These fails are caused by the parent webform wip patch for "tabbable". Whether it's the direct cause or requires some further change in webform_civicrm I don't know yet. I just know if I remove the patch this passes, but then other tests where the parent uses tabbable fail.
  1. Drupal\Tests\webform_civicrm\FunctionalJavascript\ExistingContactElementTest::testRenderingOfExistingContactElement
     WebDriver\Exception\CurlExec: Curl error thrown for http POST to http://127.0.0.1:9515/session/957d971e61889f984755237635197aa2/element/f.46EE7221EA21F835F26EF4C689E573C3.d.B8E3EBF5AD6F661480CBB911000A1458.e.469/click
  2. MultiCustomFieldsSubmissionTest::testContactRefSubmission
• Several fail with TypeError: c.isArray is not a function. This is in the parent webform: HTMLSelectElement.<anonymous> (http://127.0.0.1:8080/modules/contrib/webform/js/webform.element.select2.js?v=11.0-dev:57:19)

[KarinG]

And the new error is:

1) Drupal\Tests\webform_civicrm\FunctionalJavascript\ExistingContactElementTest::testRenderingOfExistingContactElement
WebDriver\Exception\StaleElementReference: stale element reference: stale element not found in the current frame
  (Session info: chrome-headless-shell=127.0.6533.119)
  (Driver info: chromedriver=127.0.6533.119 (bdef6783a05f0b3f885591e7d2c7b2aec1a89dea-refs/branch-heads/6533@{#1999}),platform=Linux 6.5.0-1025-azure x86_64)