Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromedriver uses a random port by default now #993

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

demeritcowboy
Copy link
Collaborator

Overview

It used to default to 9515. Now it uses a random port if not specified, so all the tests fail.

@demeritcowboy
Copy link
Collaborator Author

There may be some other change in chromedriver too. It's consistently failing here. It's where it takes a screenshot but other screenshots are working it just keeps happening in this spot:

1) Drupal\Tests\webform_civicrm\FunctionalJavascript\ContributionPayLaterTest::testSubmitContribution
WebDriver\Exception\CurlExec: Curl error thrown for http GET to http://127.0.0.1:9515/session/5b43c7bef37311d118e2346c82b6f6f5/source

The requested URL returned error: 404

/home/runner/drupal/vendor/lullabot/php-webdriver/lib/WebDriver/Exception.php:198
/home/runner/drupal/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverCurlService.php:152
/home/runner/drupal/vendor/lullabot/php-webdriver/lib/WebDriver/AbstractWebDriver.php:166
/home/runner/drupal/vendor/lullabot/php-webdriver/lib/WebDriver/AbstractWebDriver.php:287
/home/runner/drupal/vendor/lullabot/php-webdriver/lib/WebDriver/Container.php:231
/home/runner/drupal/vendor/lullabot/php-webdriver/lib/WebDriver/Session.php:579
/home/runner/drupal/vendor/lullabot/mink-selenium2-driver/src/Selenium2Driver.php:541
/home/runner/drupal/web/core/tests/Drupal/Tests/DocumentElement.php:41
/home/runner/drupal/web/core/tests/Drupal/Tests/BrowserHtmlDebugTrait.php:123
/home/runner/work/webform_civicrm/webform_civicrm/tests/src/FunctionalJavascript/WebformCivicrmTestBase.php:400
/home/runner/work/webform_civicrm/webform_civicrm/tests/src/FunctionalJavascript/ContributionPayLaterTest.php:308
/home/runner/work/webform_civicrm/webform_civicrm/tests/src/FunctionalJavascript/ContributionPayLaterTest.php:175

@KarinG
Copy link
Collaborator

KarinG commented Aug 30, 2024

Curl extension is still included
https://github.com/colemanw/webform_civicrm/blob/2fda6abf5207931eb8bc1368997e9c4d895b8cf5/.github/workflows/main.yml#L53

Other curls are working

What are we trying to curl in ContributionPayLaterTest::testSubmitContribution
I'm not seeing it.

@KarinG KarinG merged commit bd01a3e into colemanw:6.x Sep 3, 2024
4 checks passed
@demeritcowboy demeritcowboy deleted the port branch September 3, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants