CI: replace actions-rs #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razaloc
force-pushed
the
wip/rafaelgarrui/actions
branch
3 times, most recently
from
70429c1 to
c0d7b0b
Compare
obbardc
suggested changes
Dec 6, 2022
| with: | ||
| command: check | ||
| args: --all-features | ||
| - run: cargo check --all-features |
There was a problem hiding this comment.
need to split into separate commits for each logical change to the file, with a proper commit message :-)
There was a problem hiding this comment.
Even though we are changing 4 tests (check, fmt, tests and clippy) the logical way I see, to split this PR into separate commits is to split in two:
- replace actions-rs/toochain
- erase actions-rs/cargo
I avoid adding the full text of the warning because we have it in the issue #56, and could be repetitive.
Is there a better way to split it and make it more readable?
Razaloc
force-pushed
the
wip/rafaelgarrui/actions
branch
from
c0d7b0b to
e83b39b
Compare
actions-rs/toolchain is unmaintained. It uses Node.js 12 actions, which are deprecated. It raises warnings at all tests. We are replacing it with dtolnay/rust-toolchain, which uses Node.js 16 Signed-off-by: Rafael Garcia Ruiz <[email protected]>
actions-rs/cargo in unmaintained. It uses Node.js 12 actions, which are deprecated. It raises warnings at all tests. We are replacing it and just calling cargo at "run" statements Closes: #56 Signed-off-by: Rafael Garcia Ruiz <[email protected]>
Razaloc
force-pushed
the
wip/rafaelgarrui/actions
branch
from
e83b39b to
b26958b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions-rs/cargo replaced by calling cargo in run statements.
actions-rs/toochain replaced by dtolnay/rust-toolchain@stable
Closes: #56
Signed-off-by: Rafael Garcia Ruiz [email protected]