Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify upstart/systemd after initialization is complete. #4164

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

octo
Copy link
Member

@octo octo commented Nov 24, 2023

ChangeLog: Daemon: The interaction with Upstart and Systemd has been improved.

Fixes: #4152

@octo octo force-pushed the notify_upstart_systemd branch from bdebcb2 to 2ce448e Compare November 25, 2023 13:26
@eero-t
Copy link
Contributor

eero-t commented Nov 27, 2023

Changes look OK.

Btw. I wondered whether it still makes sense to continue supporting Upstart, as last LTS release to support that was Ubuntu 14.04 LTS, which standard support ended 4 years ago, and even its extended (commercial) 10 year support will end in few months (on 2024-04-25).

However, then I found out that Chrome/iumOS still uses Upstart (although there have been discussions about switching to systemd since 2014): https://www.chromium.org/chromium-os/chromiumos-design-docs/boot-design/

Copy link
Member

@mrunge mrunge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

I'd clean up for upstart in a separate patch.

@octo octo merged commit a380f7e into collectd:main Nov 27, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collectd tells the init system it's ready before it actually is
3 participants