-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title to landing page #208
Add title to landing page #208
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 555 555
Lines 12505 12508 +3
Branches 2597 2586 -11
=======================================
+ Hits 12281 12284 +3
Misses 221 221
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikejritter I think you're right about renaming LoginPage
. How about making it WelcomePage
, since that's what it really is now?
@mikejritter We could have |
f0221e0
to
dd8660d
Compare
@ray-lee Changes are now made for renaming I was having some trouble testing that the initial request on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. Never mind about redirecting / to /welcome. I forgot that / is set to redirect to /search, which requires auth, so it bounces you to the services login page. That can stay the same.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1306
This adds additional information to the page title about the purpose of the page. I was stuck between deciding on
Welcome
andLog in
(similar to the ServiceLoginPage), and ultimately settled onWeclome
. Updating the message isn't a problem if it needs to be changed.One odd thing is that the description for both the LoginPage and the ServiceLoginPlage have the same description. It might be worthwhile to simply rename to the LoginPage since it now directs the user to the login form.
How should this be tested? Do these changes have associated tests?
Welcome
Dependencies for merging? Releasing to production?
None
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested locally