Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1390: Consultation #223

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Add consultation recordtype
  • Add tests for consultation record

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1390

The consultation procedure is part of the 8.1 updates for improving NAGPRA workflows. It adds the ability to document the consultation process itself.

How should this be tested? Do these changes have associated tests?

  • Run npm run lint and npm run test as a sanity check
  • Start collectionspace using the related services and application PRs
  • Run the devserver npm run devserver
  • Create and save a consultation
  • Use the advanced search and check that field names make sense

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local instance

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (301b9c9) to head (0800689).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   98.18%   98.18%   -0.01%     
==========================================
  Files         583      590       +7     
  Lines       12645    12679      +34     
  Branches     2605     2607       +2     
==========================================
+ Hits        12416    12449      +33     
- Misses        226      227       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejritter mikejritter requested a review from ray-lee June 27, 2024 17:29
Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 6f4f6db into collectionspace:master Jul 5, 2024
4 checks passed
@mikejritter mikejritter deleted the nagpra-consultation branch July 23, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants