Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1447: Remove default values for dynamic term lists #226

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Removes default values for dynamic term lists

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1447

A user is able to remove the default values from the sources (publishto and inventorystatus), which causes the display in the field to be invalid. Note - the ticket mentions recordStatus but that field is controlled by an option picker. I believe it was just a typo, and should have been publishTo.

How should this be tested? Do these changes have associated tests?

  • Run the devserver, e.g. npm run devserver --back-end=https://core.dev.collectionspace.org
  • Go to create a collectionobject and see that the Publish to and Inventory status fields do not have default values

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (9ed0919) to head (c41be63).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         590      590           
  Lines       12679    12679           
  Branches     2593     2593           
=======================================
  Hits        12449    12449           
  Misses        227      227           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 757230d into collectionspace:master Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants