Consultation Updates #227
Merged
Consultation Updates #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 590 590
Lines 12679 12679
Branches 2593 2593
=======================================
Hits 12449 12449
Misses 227 227
Partials 3 3 ☔ View full report in Codecov by Sentry. |
mikejritter
force-pushed
the
nagpra-consultation-qa
branch
from
6f38827 to
6f06039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1390
These are changes requested based on preliminary testing of the consultation procedure. Fairly minor requests - just removing ulan from sources so they only use the
{person,org}/localauthority and some relabeling of fields.How should this be tested? Do these changes have associated tests?
involvedParty,involvedOnBehalfOf, andconsultPartyare restricted to local authoritiesinvolvedPartyandconsultPartyDependencies for merging? Releasing to production?
None
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested locally