Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1355: Deaccession Procedure #238

Merged
merged 10 commits into from
Sep 18, 2024
Merged

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Create deaccession procedure
  • Add deaccession tests

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1355

The Deaccession procedure adds the ability to capture the decision making around removing an accessioned object. Previously this was part of the ObjectExit procedure, and this is breaking it out into it's own data structure.

How should this be tested? Do these changes have associated tests?

  • Rebuild and start collectionspace
  • Run npm run test and npm run lint
  • Start the devserver npm run devserver
  • Create a deaccession procedure and ensure it saves and loads
  • Use the advanced search for a deaccession procedure and check that all messages make sense

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (949b70c) to head (0c31a89).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   98.18%   98.18%   -0.01%     
==========================================
  Files         590      597       +7     
  Lines       12682    12716      +34     
  Branches     2593     2609      +16     
==========================================
+ Hits        12452    12485      +33     
- Misses        227      228       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikejritter mikejritter marked this pull request as ready for review September 17, 2024 20:35
Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit f16c895 into collectionspace:master Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants