Fix issue 247, migration was always true. #250
Merged
+76
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works with all supported Python versions.
With previous 3.0.1 I get an error on `tox -e plone60-py311`:
```
Requires-Python support missing and could not be patched into zc.buildout.
Traceback (most recent call last):
File "/Users/maurits/zest/irceline6/src/collective.exportimport/.tox/plone60-py311/lib/python3.11/site-packages/zc/buildout/patches.py", line 66, in patch_PackageIndex
from pip._vendor import six
ImportError: cannot import name 'six' from 'pip._vendor' (/Users/maurits/zest/irceline6/src/collective.exportimport/.tox/plone60-py311/lib/python3.11/site-packages/pip/_vendor/__init__.py)
```
`zc.buildout` swallows and accepts the error, but as the error says: Requires-Python support is then missing, and we would like to have it.
Previous, you could uncheck this checkbox in `export_content`, but this was ignored. This fixes #247.
The checkbox inputs were displayed in block instead of inline with the label.
|
@pbauer The last release was in March last year. If you are happy with the current state, could you make a release please? |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #247.
Also a fix for 6.1. The boolean checkboxes in
export_contentwere displayed in block:This is because some change in Barceloneta for 6.1 sets
label input {display: block}. I guess this is fine in general, but not here.Now they are displayed inline again: