Fix CI for trilogy & rails 7.0/6.1/6.0 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketo1113
force-pushed
the
fix-ci-trilogy
branch
2 times, most recently
from
9f567b0 to
824d091
Compare
taketo1113
commented
Aug 14, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
183
to
192
| exclude: | ||
| # not exist activerecord-jdbc-adapter for trilogy | ||
| - ruby: 'jruby-9.3' | ||
| gemfiles/trilogy/6-0.gemfile | ||
| - ruby: 'jruby-9.3' | ||
| gemfiles/trilogy/6-1.gemfile | ||
| - ruby: 'jruby-9.3' | ||
| gemfiles/trilogy/7-0.gemfile | ||
| - ruby: 'jruby-9.3' | ||
| gemfiles/trilogy/7-1.gemfile |
There was a problem hiding this comment.
Exclude jruby & trilogy, activerecord-jdbc-adapter for trilogy is not exist.
Exclude ci for jruby & trilogy
taketo1113
force-pushed
the
fix-ci-trilogy
branch
from
824d091 to
a05dd19
Compare
albus522
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fix CI for trilogy & rails 7.0/6.1/6.0.
When use activerecord-trilogy-adapter gem (rails 7.0/6.1/6.0), manualy load trilogy-adapter at spec/helper.