Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode content type for POST requests #29

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

tonyelhabr
Copy link
Collaborator

MLflow requires Content-Type = "application/json" for all POST requests.

image

@porterjames
Copy link

@tonyelhabr Any idea about the failed GitHub action?

Error: Error: package or namespace load failed for 'testthat' in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]):
 namespace 'R6' 2.5.0 is being loaded, but >= 2.5.1 is required
Execution halted

@tonyelhabr
Copy link
Collaborator Author

@tonyelhabr Any idea about the failed GitHub action?

Error: Error: package or namespace load failed for 'testthat' in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]):
 namespace 'R6' 2.5.0 is being loaded, but >= 2.5.1 is required
Execution halted

ugh, yes.

how about this--i'll revert internal bumping of mlflow until i get this fixed.

@mrkaye97
Copy link
Contributor

mrkaye97 commented Jan 3, 2024

😬

yet another breaking change from the maintainers, whaddaya know

@tonyelhabr
Copy link
Collaborator Author

Tests pass on local. Current setup requires an instance of mlflow running at http://localhost:5001 (see MLFLOW_TRACKING_URI.)

@tonyelhabr tonyelhabr merged commit e39077f into main Jan 4, 2024
0 of 2 checks passed
@tonyelhabr tonyelhabr deleted the hardcode-content-type branch January 4, 2024 02:53
@tonyelhabr
Copy link
Collaborator Author

Tests pass on local. Current setup requires an instance of mlflow running at http://localhost:5001 (see MLFLOW_TRACKING_URI.)

I'll follow up at some point to fix the testing suite in the GHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants