Add support for ARIA attributes (props) #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasi
changed the title
gasi
changed the title
For now, they are all given the `String` type. After spot checking a few on MDN, that is mostly accurate, even for seemingly numeric values such `aria-valuemin`: https://developer.mozilla.org/en-US/docs/Web/API/Element/ariaValueMin#value NOTE: Despite React using `camelCase` for most props, ARIA props are indeed `kebab-case`: - https://react.dev/learn/writing-markup-with-jsx#3-camelcase-salls-most-of-the-things:~:text=the%20browser%20console.-,Pitfall,-For%20historical%20reasons - https://legacy.reactjs.org/docs/accessibility.html#wai-aria This could be improved with the following type definitions, but we’ll leave this to the implementing developer now to check support in the browser: https://use-form.netlify.app/interfaces/_node_modules__types_react_index_d_.react.ariaattributes
fsoikin
reviewed
May 13, 2024
Co-authored-by: Fyodor Soikin <[email protected]>
fsoikin
approved these changes
May 13, 2024
vineshay
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to improve accessibility of certain features, e.g. breadcrumbs from Bootstrap: https://getbootstrap.com/docs/4.6/components/breadcrumb/