Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to add possibilty to have same container in the same site.yml #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edomlag
Copy link

@edomlag edomlag commented Mar 10, 2022

My 3 modifications in run.ymal.j2

1°) To have the possibility of having the same container several times, I added the “num” field.
This field makes it possible to distinguish each container.
The field value is used in the name of the jobs and can therefore be used to identify the function of the job.
In the attached file, a job that launches the onboarding of several packages
Excerpt from this job:
- container: eri_5gc_vnf-onboard
db_project: eri_5gc_vnf-onboard
number: CCRC1.1
docker_args:
approx:
TARGET: CCRC
VNF_VERSION: V1.1

In this example, I put num: CCRC1.1 which allows me by reading the name of the jobs concerned to see that it concerns CCRC V1.1.
This gives as job name: 22_PACKAGE_ONBOARDING-CCRC1.1-127.0.0.1-eri_5gc_vnf-onboard-1.0.2-check_not_onboarded-run

2°) I also added in the template, the fact of having for each suite, the docker_args variables of the common part added to the docker_args of the suite
For your information, before in Cédric's template, only the docker_args of the suite are taken if existing, otherwise it is only those of the common part.
With my modifications, the variables below from the common part of my example are propagated in each job
docker_args:
approx:
VERBOSE: _OFF
PLATFORM: VIAAS
EVNFM_NAME: EVNFM1

3°) To be able to position the following options in multijob of jenkins, I added the management of test_properties.
tests_properties:
abort-all-job: true
aggregate-results: true
kill-phase-on: UNSTABLE
These options of a jenkins multijob are useful to determine the behavior of a scenario in case of error

Thanks
Dominique

Mes 3 modifs dans le run.ymal.j2

1°) Pour avoir la possibilité d’avoir le même container plusieurs fois, j’ai ajouté le champs « num ».
Ce champ permet de distinguer chaque container. 
La valeur du champs est utilisé dans le nom des jobs et peut donc servir pour identifier la fonction du job.
En PJ, un job qui lance le onboarding de plusieurs packages
Extrait de ce job :
        - container: eri_5gc_vnf-onboard
          db_project: eri_5gc_vnf-onboard
          num: CCRC1.1
          docker_args:
            env:
              TARGET: CCRC
              VNF_VERSION: V1.1

Dans cet exemple, j’ai mis num : CCRC1.1 qui me permet en lisant le nom des jobs concernés de voir que cela concerne CCRC V1.1.
Cela donne comme nom de job : 22_PACKAGE_ONBOARDING-CCRC1.1-127.0.0.1-eri_5gc_vnf-onboard-1.0.2-check_not_onboarded-run

2°) J’ai également ajouté dans le template, le fait d’avoir pour chaque suite, les variables docker_args de la partie commune ajouté aux docker_args de la suite 
Pour info, avant dans template de Cédric, seul les docker_args de la suite sont pris si existant, sinon c’est uniquement ceux de la partie commune.
Avec mes modifs, les variables ci-dessous de la partie commune de mon exemple sont propagées dans chaque job
      docker_args:
        env:
          VERBOSE: _OFF
          PLATFORM: VIAAS
          EVNFM_NAME: EVNFM1

3°) Pour pouvoir positionner dans multijob de jenkins les options suivantes, j’ai ajouté la gestion de test_properties.
          tests_properties:
            abort-all-job: true
            aggregate-results: true
            kill-phase-on: UNSTABLE
Ces options d’un multijob jenkins sont utiles pour déterminer le comportement d’un scénario en cas d’erreur

Voila pour les modifs
Dominique
@collivier collivier force-pushed the master branch 4 times, most recently from 2ab0c6c to 604a77d Compare May 14, 2022 13:44
@collivier collivier force-pushed the master branch 9 times, most recently from 57c6020 to 36be5a4 Compare January 18, 2023 12:59
@collivier collivier force-pushed the master branch 6 times, most recently from f14385a to 89d9cf0 Compare February 2, 2023 11:41
@collivier collivier force-pushed the master branch 10 times, most recently from 8f25150 to efd6b5f Compare February 9, 2023 16:22
@collivier collivier force-pushed the master branch 3 times, most recently from 4143be6 to b2d7540 Compare February 11, 2023 15:11
@collivier collivier force-pushed the master branch 2 times, most recently from 8318ca0 to 18dad06 Compare June 2, 2023 09:50
@collivier collivier force-pushed the master branch 11 times, most recently from 3c39260 to 95535a2 Compare July 3, 2023 17:07
@collivier collivier force-pushed the master branch 3 times, most recently from 9bdf09a to 1e7c33f Compare July 4, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant