Merge pull request #731 from colonial-heritage/fix-unit-tests

Fix unit tests
colonial-heritage · Dec 13, 2024 · 5fd6cd4 · 5fd6cd4
2 parents d6fd092 + bfaccb0
commit 5fd6cd4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/apps/researcher/src/app/[locale]/research-guide/filterGuides.test.ts b/apps/researcher/src/app/[locale]/research-guide/filterGuides.test.ts
@@ -15,7 +15,7 @@ describe('filterLevel3Guides', () => {
             },
           ],
         },
-        {id: 'level1-2'},
+        {id: 'level1-2', seeAlso: [{id: 'level2-2'}]},
       ],
     };
 
@@ -31,7 +31,7 @@ describe('filterLevel3Guides', () => {
             },
           ],
         },
-        {id: 'level1-2'},
+        {id: 'level1-2', seeAlso: [{id: 'level2-2', seeAlso: []}]},
       ],
     };
 
@@ -48,7 +48,7 @@ describe('filterLevel3Guides', () => {
           seeAlso: [
             {
               id: 'level2-1',
-              seeAlso: [{id: 'level1-2'}, {id: 'level2-2'}],
+              seeAlso: [{id: 'level1-2'}],
             },
           ],
         },

diff --git a/apps/researcher/src/app/[locale]/research-guide/filterGuides.ts b/apps/researcher/src/app/[locale]/research-guide/filterGuides.ts
@@ -37,11 +37,11 @@ export function sortResearchGuide(topLevel: ResearchGuide): ResearchGuide {
     const sortedSeeAlso =
       guide.seeAlso?.sort((a, b) =>
         (a.name || '').localeCompare(b.name || '')
-      ) || [];
+      ) || undefined;
 
     return {
       ...guide,
-      seeAlso: sortedSeeAlso.map(sortGuides),
+      seeAlso: sortedSeeAlso?.map(sortGuides),
     };
   };