-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community description #258
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Database schema changes have been appliedThe development database migrated with the migrations found in this branch. Warning: All preview and development environments use the same database. This migration can affect all preview and development environments. After merging this pull request, the development database changes will merge into the production database. |
barbarah
force-pushed
the
communityDescription
branch
from
September 27, 2023 09:14
c73a116
to
95b11e4
Compare
barbarah
force-pushed
the
communityDescription
branch
from
September 27, 2023 09:19
95b11e4
to
0ca35ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for: #248
Show and edit community description.
I used Clerk metadata for saving the description.
There was no design for the edit, so I tried to make it simple but still fit in the design.
The maximum for metadata for the entire metadata object. I have limited it to 2000 characters so that we could use the metadata for other fields in the future. On the communities overview, a max of 3 lines is visible; this was not in the design, but I thought it was necessary.
I had trouble showing the new description on the page after saving it.
revalidatePath()
was not enough. Because Clerk is a third-party API I could not only revalidate one fetch function. The only thing that worked was addingexport const fetchCache = 'force-no-store';
to the page.TODO