Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community description #258

Closed
wants to merge 9 commits into from
Closed

Community description #258

wants to merge 9 commits into from

Conversation

barbarah
Copy link
Contributor

@barbarah barbarah commented Sep 27, 2023

Waiting for: #248

Show and edit community description.

I used Clerk metadata for saving the description.

There was no design for the edit, so I tried to make it simple but still fit in the design.

The maximum for metadata for the entire metadata object. I have limited it to 2000 characters so that we could use the metadata for other fields in the future. On the communities overview, a max of 3 lines is visible; this was not in the design, but I thought it was necessary.

I had trouble showing the new description on the page after saving it. revalidatePath() was not enough. Because Clerk is a third-party API I could not only revalidate one fetch function. The only thing that worked was adding export const fetchCache = 'force-no-store'; to the page.

TODO

  • button 'edit description' is always visible
  • Missing translation Community.serverError

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
colonial-collections-dataset-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 9:21am
colonial-collections-researcher ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 9:21am

@github-actions
Copy link

Database schema changes have been applied

The development database migrated with the migrations found in this branch.

Warning: All preview and development environments use the same database. This migration can affect all preview and development environments.

After merging this pull request, the development database changes will merge into the production database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant