Add object to list #272
Merged
Add object to list #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Database schema changes have been appliedThe development database migrated with the migrations found in this branch. Warning: All preview and development environments use the same database. This migration can affect all preview and development environments. After merging this pull request, the development database changes will merge into the production database. |
|
@sdevalk, I just removed you as a reviewer. There is a bug in my last changes. |
barbarah
force-pushed
the
add-object-to-list
branch
from
27052ba to
ed6683f
Compare
sdevalk
reviewed
Oct 10, 2023
apps/researcher/src/app/[locale]/objects/[id]/object-lists-actions.ts
Outdated
Show resolved
Hide resolved
apps/researcher/src/app/[locale]/objects/[id]/object-lists-actions.ts
Outdated
Show resolved
Hide resolved
apps/researcher/src/app/[locale]/objects/[id]/object-lists-menu.tsx
Outdated
Show resolved
Hide resolved
apps/researcher/src/app/[locale]/objects/[id]/object-lists-menu.tsx
Outdated
Show resolved
Hide resolved
sdevalk
reviewed
Oct 12, 2023
apps/researcher/src/app/[locale]/objects/[id]/object-lists-actions.ts
Outdated
Show resolved
Hide resolved
apps/researcher/src/app/[locale]/objects/[id]/object-lists-menu.tsx
Outdated
Show resolved
Hide resolved
sdevalk
approved these changes
Oct 19, 2023
barbarah
force-pushed
the
add-object-to-list
branch
from
0cfdc7f to
a2d8ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add a dropdown to the object detail page. The user can choose a list to add the object to. After adding the object, the object is shown on the community page.
The design of the object list dropdown I made myself, and maybe needs some changes later.
I made two schema changes:
1:
objectItem.listIdcould be null. AnobjectItemwithout a list makes no sense, so I made this property not null.2: The
objectItem.objectId(hashed URI) was the primary key. But objectId is not unique because objects can be added to multiple lists. So, I have addedobjectItem.idwith an auto-increment and made this the primary key.