Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searchable multi select facets #288

Merged
merged 20 commits into from
Nov 1, 2023
Merged

Searchable multi select facets #288

merged 20 commits into from
Nov 1, 2023

Conversation

barbarah
Copy link
Contributor

@barbarah barbarah commented Oct 18, 2023 •
edited
Loading

This is the new searchable multi-select facet.

There are still discussions about number_count and maybe a different facet for materials. So, this is just the first version.

@barbarah barbarah marked this pull request as draft October 18, 2023 14:27
@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
colonial-collections-dataset-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 8:42am
colonial-collections-researcher ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 8:42am

@barbarah barbarah changed the title feature: searchable facets feature: searchable multi select facets Oct 26, 2023
@barbarah barbarah marked this pull request as ready for review October 26, 2023 09:04
@barbarah barbarah requested a review from sdevalk October 26, 2023 09:04
@barbarah barbarah changed the title feature: searchable multi select facets Searchable multi select facets Oct 26, 2023
sdevalk
sdevalk reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@sdevalk sdevalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

apps/researcher/src/messages/en/messages.json Outdated Show resolved Hide resolved
apps/researcher/src/messages/en/messages.json Outdated Show resolved Hide resolved
packages/list-store/src/use-searchable-facet.tsx Outdated Show resolved Hide resolved
packages/list-store/src/use-searchable-facet.tsx Outdated Show resolved Hide resolved
packages/list-store/src/use-searchable-facet.tsx Outdated Show resolved Hide resolved
packages/list-store/src/use-searchable-facet.tsx Outdated Show resolved Hide resolved
packages/list-store/src/use-searchable-facet.tsx Outdated Show resolved Hide resolved
packages/list-store/src/use-searchable-facet.tsx Outdated Show resolved Hide resolved
packages/ui/list/multi-select-facet.tsx Outdated Show resolved Hide resolved
@barbarah barbarah requested a review from sdevalk October 31, 2023 10:46
sdevalk
sdevalk approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@sdevalk sdevalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've added one question.

packages/list-store/src/use-searchable-facet.tsx Outdated Show resolved Hide resolved
@barbarah barbarah merged commit e414bad into main Nov 1, 2023
4 checks passed
@barbarah barbarah deleted the searchable-facet branch November 1, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdevalk sdevalk sdevalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barbarah @sdevalk