Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore terms with 0 results; return up to 10000 terms #308

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: ignore terms with 0 results; return up to 10000 terms #308

merged 1 commit into from
Nov 7, 2023

Conversation

sdevalk
Copy link
Contributor

@sdevalk sdevalk commented Nov 3, 2023 •
edited
Loading

This PR:

  1. No longer returns facet values with a count of 0 (this is a test, to find out whether it improves the search experience)
  2. Returns up to 10,000 facets values per facet (this is a bad practice that we must revisit at some point, but allows us to see all or at least most of the facet values that we currently have in the data)

@vercel Vercel
Copy link

vercel bot commented Nov 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
colonial-collections-dataset-browser ✅ Ready (Inspect) Visit Preview Nov 3, 2023 11:49am
colonial-collections-researcher ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 11:49am

@sdevalk sdevalk requested a review from barbarah November 3, 2023 11:12
barbarah
barbarah reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@barbarah barbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. The end-to-end tests should succeed with the test data.

I have created a new pull request with some front-end changes: #314

@sdevalk sdevalk requested a review from barbarah November 7, 2023 09:12
@sdevalk sdevalk merged commit 19329e4 into main Nov 7, 2023
3 checks passed
@sdevalk sdevalk deleted the search-ignore-0-return-10000-terms branch November 7, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbarah barbarah barbarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdevalk @barbarah