Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store and retrieve Local Contexts Notices enrichments #654

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

sdevalk
Copy link
Contributor

@sdevalk sdevalk commented Jun 13, 2024

This PR expands the enricher package: it allows you to store and retrieve enrichments about Local Contexts Notices.

The backing data model for storing the enrichments (as nanopublications) could still change a bit, but it shouldn't really impact the way that you use the API.

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
colonial-collections-dataset-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 6:25pm
colonial-collections-researcher ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 6:25pm

@sdevalk sdevalk requested a review from barbarah June 13, 2024 15:18
Copy link
Contributor

@barbarah barbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a working (not finished) frontend with this API, works as expected. I have one question about a property that is not used in the design. You can choose to ignore this.

@sdevalk sdevalk merged commit b512c50 into main Jun 20, 2024
6 checks passed
@sdevalk sdevalk deleted the feat-enricher-local-contexts-notices branch June 20, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants