Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hasParts property #732

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat: hasParts property #732

merged 1 commit into from
Dec 13, 2024

Conversation

sdevalk
Copy link
Contributor

@sdevalk sdevalk commented Dec 13, 2024

This PR adds a new property to a research guide: hasParts. A research guide previously only had one relationship to other guides, seeAlso. But this relationship was too broad: it did not make clear that a research guide was a part of another research guide. This causes presentation issues in the frontend: the overview page displays all research guides that are somehow related, not just the ones that are hierarchically related. The hasParts property aims to fix this.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
colonial-collections-dataset-browser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 8:46am
colonial-collections-researcher ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 8:46am

@sdevalk sdevalk requested a review from barbarah December 13, 2024 08:50
@sdevalk sdevalk merged commit d7a55c1 into main Dec 13, 2024
4 of 6 checks passed
@sdevalk sdevalk deleted the feat-research-guide-has-parts branch December 13, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants