Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Commit

Permalink
Make gts work with workspaces
Browse files Browse the repository at this point in the history
I noticed that gts fix and gts link wasn't working in the npm workspaces. This is related to the issues:

gts monorepo does not work with npm ? google/gts#752
gts does not work in a yarn workspaces monorepo google/gts#490
The last issue is with yarn but has more discussion. One solution was using nohoist. This is not a default option with npm. So I tried with the following package https://github.com/zgriesinger/noist. But this did not fix the errors. The last solution mentioned was only linting from the root level; this works.

I have also subscribed to the issue [feature] support npm workspaces. There may be a better solution in the future.
  • Loading branch information
barbarah committed Apr 12, 2023
1 parent 43a460f commit 29d6763
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 63 deletions.
2 changes: 0 additions & 2 deletions apps/dataset-browser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
"build": "next build",
"compile": "tsc",
"dev": "next dev",
"fix": "gts fix",
"lint": "gts lint",
"start": "next start",
"test": "jest --passWithNoTests --testPathIgnorePatterns '<rootDir>/src/.*/*.integration.test.ts'",
"test:ci": "npm test -- --ci",
Expand Down
60 changes: 0 additions & 60 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
"scripts": {
"build": "turbo run build",
"dev": "turbo run dev",
"lint": "turbo run lint",
"fix": "gts fix",
"lint": "gts lint",
"format": "prettier --write \"**/*.{ts,tsx,md}\""
},
"devDependencies": {
Expand Down
8 changes: 8 additions & 0 deletions packages/ui/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
module.exports = {
root: true,
extends: ['custom'],
rules: {
'node/no-unpublished-require': [
'error',
{
allowModules: ['tailwind-config'],
},
],
},
};

0 comments on commit 29d6763

Please sign in to comment.