-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for windows x64 machines #69
base: master
Are you sure you want to change the base?
Conversation
Fix for windows x64 machines
@pf-bajorek Thanks - the build is failing though because of the changed where/which line for the windows tests. Could you fix that test please? |
@colszowka Hi!
The error encourage because it is executed on linux machine:
I don't know whether trevis can run tests on windows? What do you do to fix this test? Skip it on unix machines? |
The test suite is built to simulate the corresponding platforms by stubbing out the respective root calls, see the setup block of the failing test in https://github.com/colszowka/phantomjs-gem/blob/master/spec/platform_spec.rb#L177 :) |
@colszowka done :) |
So, will it be merged? |
ping |
@colszowka Are you planing to merge this issue to master and push new gem version? |
I would suggest 2 additional changes. To account for more windows setups (mine identifies as mswin32): def useable?
host_os =~ /mingw|mswin|cygwin/
end To account for multiple phantomjs.exe on path: def system_phantomjs_path
`where phantomjs`.split("\n")[0]
rescue
end
`` |
where
instead ofwhich