Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't download if package file exists; use ENV['PHANTOMJS_URL'] #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't download if package file exists; use ENV['PHANTOMJS_URL'] #82

wants to merge 1 commit into from

Conversation

jamilbk
Copy link

@jamilbk jamilbk commented May 2, 2016

  1. Don't download if package file already exists.
  2. Use ENV['PHANTOMJS_URL'] if provided.

@werkshy
Copy link

werkshy commented Apr 3, 2017

A sensible check IMO!

Just a note that this takes a slightly different approach to the PHANTOM_DOWNLOAD_URL_BASE used in #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants