Jacques/evaluate prompt #1023
Merged
Jacques/evaluate prompt #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkuzmik
requested changes
Jan 13, 2025
| processed_messages.append( | ||
| { | ||
| "role": message["role"], | ||
| "content": pystache.render(message["content"], prompt_variables), |
There was a problem hiding this comment.
I think you can use opik.api_objects.prompt.prompt_template.PromptTemplate class. It does pretty much the same stuff as pystache and has special errors for the cases when variables don't match the template.
There was a problem hiding this comment.
Updated but I had to turn off the validation since we only want the validation only if one of the variables in the prompt is not updated. But at least we don't have an extra dependency
|
|
||
| verbose: an integer value that controls evaluation output logs such as summary and tqdm progress bar. | ||
| """ | ||
| if isinstance(model, str): |
There was a problem hiding this comment.
if isinstance(model, str):
model = models_factory.get(model_name=model)
elif not isinstance(model, base_model.OpikBaseModel):
raise ValueError("`model` must be either a string or an OpikBaseModel instance")
…name from the parent span to the params, add error_callback as well
alexkuzmik
previously approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Updated the evaluation documentation and fixed various issues in the docs