[NA] fix gemini streaming #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
previously approved these changes
Jan 22, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderGemini.java
Show resolved
Hide resolved
aadereiko
reviewed
Jan 22, 2025
...-backend/src/test/java/com/comet/opik/api/resources/v1/priv/ChatCompletionsResourceTest.java
Outdated
Show resolved
Hide resolved
andrescrz
reviewed
Jan 22, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderGemini.java
Show resolved
Hide resolved
...-backend/src/test/java/com/comet/opik/api/resources/v1/priv/ChatCompletionsResourceTest.java
Outdated
Show resolved
Hide resolved
andrescrz
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
FE reported that Gemini streaming isn't working properly:
I was able to reproduce locally and noticed that
GoogleAiGeminiStreamingChatModel::generate()is blocking and therefore the chat completions endpoint only responds when the above is finished.This PR fixes the issue as you can see in this video:
Testing
Tested locally by running the application and calling the relevant endpoint.