Update extra_config.py

[dchatel]

added path normalization to full_path.

needed to ensure that line 204 in folder_paths.py: if full_folder_path in paths: works properly on all OS.

[bigcat88]

needed to ensure that line 204 in folder_paths.py: if full_folder_path in paths: works properly on all OS.

In my opinion, a good start would be to modify existing tests or add a new test that explains why these changes are necessary.

[dchatel]

An example of why this is at least desirable is that without this, if a user sets a custom base_path and is_default to true, then the model downloader in comfyui-manager does not work as intended.

You can try it yourself: set the base_path somewhere external to comfyui, set is_default to true, then try to download a model using comfyui-manager, or let a custom node download its own model (like comfyui-florence2). You'll see that the models get download inside the comfyui/model folder instead of the one you've set in base_path.

[bigcat88]

Then this is not quite the correct implementation for this.

There can be many be several records with is_default for different folder paths, it is impossible to determine which of them should ultimately overwrite the root models_dir.

Currently software that performs download should look under the specific keys in the global folder_names_and_paths variable and get path to store models from it.

@comfyanonymous would you like to extend the functionality of the yaml file and allow it to set the models_dir variable?

[iwr-redmond]

In #5864, @vvuk suggested that base paths be processed in the order they were defined in extra_models_paths.yaml, with the first to be defined taking precedence.

[vvuk]

(I'd appreciate some feedback/guidance in #5864 -- I'm not quite sure what the dev process is here, let me know if I should be doing something else for PR submissions!)

[iwr-redmond]

There appears to be a backlog of YAML file PRs:

#2720 by @soof-golan
#3744 by @iwanders
#4365 by @ltdrdata