Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console errors #562

Closed
wants to merge 10 commits into from
Closed

fix: console errors #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e2c1af
reset and add notes again
michael-odonovan Apr 25, 2023
efa3789
Empty commit to trigger build
michael-odonovan Apr 25, 2023
8743229
update @babel/cli
michael-odonovan Apr 25, 2023
535caa7
update axios
michael-odonovan Apr 25, 2023
9584ca9
update ejs
michael-odonovan Apr 25, 2023
267f371
update jest and jest-styled-components
michael-odonovan Apr 25, 2023
2da2c60
more checks
michael-odonovan Apr 25, 2023
0dc539f
Empty commit to trigger build
michael-odonovan Apr 25, 2023
d99aa3b
fix import axios error
michael-odonovan Apr 25, 2023
37378d9
change onClick to onChange in GivingSelector
michael-odonovan Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions package-update-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
## working process:
`yarn outdated`
`yarn update@^{package}`

### output:
Package Current Wanted Latest Package Type URL
@babel/cli 7.14.8 7.21.0 7.21.0 dependencies https://babel.dev/docs/en/next/babel-cli

axios 0.21.1 0.21.4 1.3.6 dependencies https://axios-http.com
ejs 3.1.6 3.1.6 3.1.9 resolutionDependencies https://github.com/mde/ejs
jest 26.6.3 26.6.3 29.5.0 devDependencies https://jestjs.io/
jest-styled-components 7.0.5 7.1.1 7.1.1 dependencies https://github.com/styled-components/jest-styled-components#readme




@hookform/resolvers 1.3.7 1.3.8 3.1.0 dependencies https://react-hook-form.com
cypress 8.3.0 8.7.0 12.10.0 devDependencies https://github.com/cypress-io/cypress
eslint 7.32.0 7.32.0 8.39.0 devDependencies https://eslint.org
eslint-config-airbnb 18.2.1 18.2.1 19.0.4 devDependencies https://github.com/airbnb/javascript
eslint-plugin-import 2.24.2 2.27.5 2.27.5 devDependencies https://github.com/import-js/eslint-plugin-import
eslint-plugin-jsx-a11y 6.4.1 6.7.1 6.7.1 devDependencies https://github.com/jsx-eslint/eslint-plugin-jsx-a11y#readme
eslint-plugin-react 7.24.0 7.32.2 7.32.2 devDependencies https://github.com/jsx-eslint/eslint-plugin-react
eslint-plugin-react-hooks 4.2.0 4.6.0 4.6.0 devDependencies https://reactjs.org/
husky 7.0.2 7.0.4 8.0.3 devDependencies https://typicode.github.io/husky
jest-styled-components 7.0.5 7.1.1 7.1.1 dependencies https://github.com/styled-components/jest-styled-components#readme
moment 2.29.1 2.29.4 2.29.4 dependencies https://momentjs.com
prettier 2.3.2 2.8.8 2.8.8 devDependencies https://prettier.io
prop-types 15.7.2 15.8.1 15.8.1 dependencies https://facebook.github.io/react/
react 17.0.2 17.0.2 18.2.0 dependencies https://reactjs.org/
react-canvas-confetti 1.3.0 1.4.0 1.4.0 dependencies https://github.com/ulitcos/react-canvas-confetti#readme
react-currency-format 1.0.0 1.1.0 1.1.0 dependencies https://github.com/mohitgupta8888/react-currency-format#readme
react-dom 17.0.2 17.0.2 18.2.0 dependencies https://reactjs.org/
react-hook-form 6.15.8 6.15.8 7.43.9 dependencies https://www.react-hook-form.com
react-modal 3.14.3 3.16.1 3.16.1 dependencies https://github.com/reactjs/react-modal
react-responsive 9.0.0 9.0.2 9.0.2 dependencies http://github.com/contra/react-responsive
react-scripts 4.0.3 4.0.3 5.0.1 dependencies https://github.com/facebook/create-react-app#readme
react-spinners 0.11.0 0.11.0 0.13.8 dependencies https://www.davidhu.io/react-spinners/
react-styleguidist 11.1.7 11.2.0 13.1.1 dependencies https://github.com/styleguidist/react-styleguidist
react-test-renderer 17.0.2 17.0.2 18.2.0 dependencies https://reactjs.org/
react-uid 2.3.1 2.3.2 2.3.2 dependencies https://github.com/thearnica/react-uid#readme
semantic-release 17.4.6 17.4.7 21.0.1 devDependencies https://github.com/semantic-release/semantic-release#readme
styled-components 5.3.1 5.3.10 5.3.10 dependencies https://styled-components.com/
youtube-player 5.5.2 5.6.0 5.6.0 dependencies https://github.com/gajus/youtube-player#readme
yup 0.32.9 0.32.11 1.1.1 dependencies https://github.com/jquense/yup



## log of package updates:
- @babel/cli: 7.14.8 - 7.21.0 => no breaking changes in changelog
- [X] checked Component Library local server still working
- [X] check styleguide:build is ok

- axios 1.3.7 - 3.1.0 => some "Deprecated" in 1.0 in changelog
- [X] checked Component Library local server still working
- [X] check styleguide:build is ok

- ejs 3.1.6 - 3.1.9 => no breaking changes in changelog
- [X] checked Component Library local server still working
- [X] check styleguide:build is ok

- jest 26.6.3 - 29.5.0 => Drop support for Node v10 and v15 and target first LTS 16.13.0 (#12220)
- [X] checked Component Library on local server
- [X] check styleguide:build is ok

- jest-styled-components 7.0.5 - 7.1.1
- [X] yarn styleguide:build
- [X] yarn styleguide
- [X] yarn cy:run
- [X] yarn test (jest)
11 changes: 6 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@
"url": "https://github.com/comicrelief/component-library.git"
},
"dependencies": {
"@babel/cli": "^7.14.8",
"@babel/cli": "^7.21.0",
"@hookform/resolvers": "^1.3.4",
"axios": "^0.21.1",
"jest-styled-components": "^7.0.5",
"axios": "^1.3.6",
"ejs": "^3.1.9",
"jest-styled-components": "^7.1.1",
"lazysizes": "^5.3.2",
"lodash": "^4.17.11",
"moment": "^2.29.1",
Expand All @@ -49,7 +50,7 @@
"react-scripts/workbox-webpack-plugin/workbox-build/@surma/rollup-plugin-off-main-thread/ejs": "3.1.6"
},
"scripts": {
"test": "yarn run jest",
"test": "yarn run jest --transformIgnorePatterns 'node_modules/(?!axios)/'",
"styleguide": "cross-env FAST_REFRESH=false styleguidist server",
"styleguide:build": "styleguidist build",
"postinstall": "yarn run build",
Expand Down Expand Up @@ -83,7 +84,7 @@
"eslint-plugin-react": "^7.24.0",
"eslint-plugin-react-hooks": "^4.0.5",
"husky": "^7.0.2",
"jest": "^26.1.0",
"jest": "^29.5.0",
"npm-run-all": "^4.1.5",
"prettier": "^2.3.2",
"semantic-release": "^17.4.6"
Expand Down
4 changes: 2 additions & 2 deletions src/components/Organisms/Donate/GivingSelector/GivingSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const GivingSelector = ({
label=""
errormsg=""
checked={givingType === 'single'}
onClick={() => handleGivingTypeChange('single', givingType)}
onChange={() => handleGivingTypeChange('single', givingType)}
/>
<Label active={givingType === 'single'} htmlFor={`give-once--${mbshipID}`}>
Single
Expand All @@ -42,7 +42,7 @@ const GivingSelector = ({
label=""
errormsg=""
checked={givingType === 'monthly'}
onClick={() => handleGivingTypeChange('monthly', givingType)}
onChange={() => handleGivingTypeChange('monthly', givingType)}
/>
<Label active={givingType === 'monthly'} htmlFor={`give-monthly--${mbshipID}`}>
Monthly
Expand Down
Loading