feat: Allows Logos to be exported, and adds ability to customise title #701
Conversation
| <Logos animateRotate sizeSm="50px" sizeMd="60px" /> |
There was a problem hiding this comment.
We've previously had logos rotated a bit (by default, not on hover), so would rather we don't make this PR destructive in that respect
There was a problem hiding this comment.
There was a problem hiding this comment.
Although I guess this is just an example, so doesn't matter, now I thiink about it for 10 seconds
There was a problem hiding this comment.
Yeah I wasn't sure about it, opted for it just to help show off the possible functionality within the CL, I reckon if there is functionality that's not immediately obvious it's always good to enable it, for the purposes of demoing it in your CL showcase thingy
There was a problem hiding this comment.
Could always add a second example that covers this functionality, leaving the previous one in place (with some descriptive titles above); makes for even-clearer explanation of what we have and how to use it.
There was a problem hiding this comment.
Good shout. I've got two examples in place instead:
There was a problem hiding this comment.
Looking good man; just now a bit confused why we ever had Logo and Logos in the first place 🤔
Looks like Logos is pretty specific to the header nav, and it sometimes includes more than one Logo.. but always contains a link.
Move to rename Logos to LogosWithLink or something, to delineate?
I agree. Changing now... |
|
🎉 This PR is included in version 8.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I'll spin up a CRcom PR to bring in these changes, updating the usage accordingly Edit: didn't even need to; no direct usage |
PR description
What is it doing?
Allows 'Logos' to be used in the frontend as it's not currently an export, and also allows a custom 'title' prop
Why is this required?
So that the logo can be used across multiple headers in various repos
link to Jira ticket:
DF-205