visionbuf: fix incorrect length passed to munmap #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adurham
added a commit
to adurham/msgq
that referenced
this pull request
Sep 20, 2024
commit cdcf84f Author: Shane Smiskol <[email protected]> Date: Tue Aug 27 20:10:33 2024 -0700 Better compiler compatibility commit cff3a55 Author: Dean Lee <[email protected]> Date: Sat Aug 24 01:42:31 2024 +0800 remove libcereal_shared from .gitignore (commaai#630) remove shared creal commit 23cb05a Author: Dean Lee <[email protected]> Date: Mon Aug 5 06:02:07 2024 +0800 visionbuf: fix incorrect length passed to munmap (commaai#618) Fix incorrect length passed to munmap commit 622de23 Author: Dean Lee <[email protected]> Date: Mon Aug 5 05:53:06 2024 +0800 msgq: check MAP_FAILED instead of NULL for mmap (commaai#614) commit 45110ff Author: Shane Smiskol <[email protected]> Date: Wed Jul 31 21:49:42 2024 -0700 fix mypy configuration header (commaai#629) did this work? commit 37e734b Author: Shane Smiskol <[email protected]> Date: Wed Jul 31 19:09:21 2024 -0700 fix PYTHONPATH (commaai#628) pythonpath was wrong, the location is what saved us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a bug in VisionBuf::free() where an incorrect length parameter was passed to munmap(), potentially causing memory issues.
In the allocate() method, the length of the memory mapping (mmap_len) was calculated as
this->len + sizeof(uint64_t). However, in the free() method, only this->len was used as the length parameter for munmap(), resulting in an incorrect length.