Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI with preview #1

Merged
merged 4 commits into from
Jun 9, 2024
Merged

CI with preview #1

merged 4 commits into from
Jun 9, 2024

Conversation

incognitojam
Copy link
Member

@incognitojam incognitojam commented Jun 9, 2024 •
edited
Loading

  • Regenerated lockfile (needed for pnpm v9, figured we didn't need to preserve it)
  • Added CI workflows for deploying previews similar to connect
  • Fixed type errors preventing build

@incognitojam incognitojam marked this pull request as draft June 9, 2024 18:51
@incognitojam incognitojam marked this pull request as ready for review June 9, 2024 18:54
@incognitojam
Copy link
Member Author

not sure why preview workflow didn't run! copied it from connect pretty much exactly. might be because it uses secrets

@adeebshihadeh
Copy link
Contributor

not sure why preview workflow didn't run! copied it from connect pretty much exactly. might be because it uses secrets

Needs to be merged to master to run.

@adeebshihadeh adeebshihadeh merged commit faa0e3a into commaai:master Jun 9, 2024
1 check passed
@incognitojam incognitojam deleted the ci-preview branch June 9, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@incognitojam @adeebshihadeh