Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add European (2020) HYUNDAI_KONA_HEV fp #1660

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

twilsonco
Copy link

This is for @elruidomepeta's (on Discord) 2020 Hyundai Kona HEV in Spain.

Route of successful recognition on master with these changes: 69e57686816b982c/00000010--18ca001831/0

@github-actions github-actions bot added car related to opendbc/car/ hyundai fingerprint labels Jan 23, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@twilsonco twilsonco marked this pull request as draft January 24, 2025 07:17
@twilsonco
Copy link
Author

twilsonco commented Jan 24, 2025

The fingerprint works fine, but OP has no long control. Inspecting logs, it sends commands but the car doesn't respond.

Comparing commands sent by SCC with those sent by OP, I found some differences that may be responsible for it not responding to OP ACC commands. I'll see if I can get that resolved, then this PR with coincide with one to make the necessary changes to hyundaican.py.

@twilsonco
Copy link
Author

twilsonco commented Jan 26, 2025

I wasn't able to resolve the issues with long control by trying to better mimic the SCC commands the car was using when in dashcam mode.

I'm submitting this as is so that @elruidomepeta can run master. After that, I'll work with him to record fresh routes to capture the problem and investigate the long control issue further.

@twilsonco twilsonco marked this pull request as ready for review January 26, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ fingerprint hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant