FIx violations and enable --warn=all

[bongbui321]

Description [](A description of the refactor, including the goals it accomplishes.)
For #29500, Fix violations and enable warn=all

[adeebshihadeh]

Is this really the source of the remaining warnings? This is a pretty core part of SCons, and we shouldn't be doing this scanning ourselves.

Is there a cleaner way to properly fix this? Maybe we can filter these warnings instead?

[bongbui321]

@adeebshihadeh I looked into it and I agree that we shouldn't replace SCons Scanner. I replaced the default ClassicCPP SCanner with CConditional Scanner which resolves (#ifdef, etc) statements and not include non-existing file.

However, I made some modification to the Source Code and ignore the C standard files, poetry virtualenv (.venv folder) and apt packages since we never explicitly modify these files. Also Having these files being scanned slows down the compilation time significantly since there are alot.

The test cases are failing because of the issue here. When that PR is merged, it should compile normally

Also I talked to scons maintainer, and he agrees that missing system header files warning might be change in the future. So I think this temporal implementation right now works fine.

[adeebshihadeh]

Works only with the assumption that every important implicit dependency is within the repo

Unfortunately, we rely on that behavior, e.g. when we update the Python version.

Thanks for tracking all this stuff down. As is the case sometimes with the bounties, this one doesn't seem feasible to ship right now. Let's just merge the "SetOption('warn', 'all')" but commented out and a link to the issue you linked above it, then we can revisit once SCons addresses this upstream. Once that's done, consider this bounty solved!

[adeebshihadeh]

@bongbui321 want to try one of the bounties here? commaai/panda#1770

should be relatively straightforward and if you want, there's lots of bounties to be made from fixing these https://github.com/commaai/panda/pull/926/files#diff-999690623aab48a8f875013ed611bf2726efc87b076bbbd09ad7bb6d6dbeaec7R15

[bongbui321]

Will have a try.