Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Biome #102

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Move to Biome #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13964f9
chore: replace eslint with biomejs
marcomontalbano Jan 24, 2025
2988d27
chore: add lint script to the root
marcomontalbano Jan 28, 2025
f1b08e2
chore: reset 'trailingCommas' to default
marcomontalbano Jan 28, 2025
9c5862c
chore: reset 'quoteStyle' to default
marcomontalbano Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .ncurc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ module.exports = {
],
filterResults: (name, { upgradedVersionSemver }) => {
if (
name === '@types/node' && parseInt(upgradedVersionSemver?.major) >= 22 ||
name === 'eslint' && parseInt(upgradedVersionSemver?.major) >= 9
name === '@types/node' && Number.parseInt(upgradedVersionSemver?.major) >= 22
) {
return false
}
Expand Down
31 changes: 31 additions & 0 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
"vcs": {
"enabled": false,
"clientKind": "git",
"useIgnoreFile": false
},
"files": {
"ignoreUnknown": false,
"ignore": []
},
"formatter": {
"enabled": true,
"indentStyle": "space",
"indentWidth": 2
},
"organizeImports": {
"enabled": true
},
"linter": {
"enabled": true,
"rules": {
"recommended": true
}
},
"javascript": {
"formatter": {
"semicolons": "asNeeded"
}
}
}
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
"preinstall": "npx only-allow pnpm",
"build": "pnpm --filter js-auth build",
"prepare": "husky",
"lint": "pnpm --filter js-auth lint",
"lint:fix": "pnpm --filter js-auth lint:fix",
"test": "pnpm --filter js-auth test",
"test:production": "pnpm --filter js-auth test -- --mode production",
"test:watch": "pnpm --filter js-auth test:watch",
Expand All @@ -18,7 +20,7 @@
"dep:minor": "pnpm dep:major -t minor"
},
"devDependencies": {
"@commercelayer/eslint-config-ts": "^1.4.5",
"@biomejs/biome": "^1.9.4",
"husky": "^9.1.7",
"lerna": "^8.1.9",
"replace-in-file": "^8.3.0",
Expand Down
9 changes: 0 additions & 9 deletions packages/js-auth/.eslintrc.cjs
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions packages/js-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
},
"homepage": "https://github.com/commercelayer/commercelayer-js-auth#readme",
"scripts": {
"lint": "eslint src --ext .ts,.tsx",
"lint:fix": "eslint src --ext .ts,.tsx --fix",
"lint": "pnpm biome check src",
"lint:fix": "pnpm biome check src --write",
"test": "pnpm run lint:fix && vitest run",
"test:watch": "vitest",
"build": "tsup",
Expand Down
Loading
Loading