make fields optional by default

commercetools · Feb 23, 2022 · 4b4f2c6 · 4b4f2c6
1 parent 0ee68c2
commit 4b4f2c6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "commercetools-php-sdk-changelog",
-  "version": "2.17.0",
+  "version": "2.17.1-beta.1",
   "description": "commercetools PHP SDK changelog generator package description",
   "homepage": "https://github.com/commercetools/commercetools-php-sdk",
   "bugs": "https://github.com/commercetools/commercetools-php-sdk/issues",

diff --git a/src/Core/AbstractHttpClient.php b/src/Core/AbstractHttpClient.php
@@ -14,7 +14,7 @@
  */
 abstract class AbstractHttpClient
 {
-    const VERSION = '2.17.0';
+    const VERSION = '2.17.1-beta.1';
 
     /**
      * @var AdapterInterface

diff --git a/src/Core/Model/Common/JsonObject.php b/src/Core/Model/Common/JsonObject.php
@@ -192,7 +192,7 @@ protected function initialize($field)
 
     public function isOptional($field)
     {
-        return $this->fieldDefinitionValue($field, static::OPTIONAL, false);
+        return $this->fieldDefinitionValue($field, static::OPTIONAL, true);
     }
 
     protected function decorateField($field, $value)

diff --git a/tests/unit/Model/Common/JsonObjectTest.php b/tests/unit/Model/Common/JsonObjectTest.php
@@ -35,7 +35,7 @@ protected function getObject()
             ->will(
                 $this->returnValue(
                     [
-                        'key' => [JsonObject::TYPE => 'string'],
+                        'key' => [JsonObject::TYPE => 'string', JsonObject::OPTIONAL => false],
                         'dummy' => [JsonObject::TYPE => 'string'],
                         'true' => [JsonObject::TYPE => 'bool'],
                         'false' => [JsonObject::TYPE => 'bool'],
@@ -243,7 +243,7 @@ public function testOptional()
                 $this->returnValue('12345')
             );
 
-        $this->assertFalse($obj->isOptional('implicit'));
+        $this->assertTrue($obj->isOptional('implicit'));
         $this->assertTrue($obj->isOptional('optional'));
         $this->assertFalse($obj->isOptional('required'));
     }