Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding mc-app example to application kit #70

Merged

Conversation

dario-commercetools
Copy link
Contributor

Link to the Jira issue

[IM-571] https://commercetools.atlassian.net/browse/IM-571

Description and context

Adding example of mc-app application

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Brief description of the solution

How was it tested?

Instructions to build/test locally

Depends on another PR/branch?

  • No
  • Yes - dependant on PR/branch:

Checklist-

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • I joined a screenshot of the app before and after the fix.

[upload the screenshot here]

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

⚠️ No Changeset found

Latest commit: d7150db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

application-templates/typescript/connect.yaml Outdated Show resolved Hide resolved
application-templates/javascript/connect.yaml Outdated Show resolved Hide resolved
@dario-commercetools dario-commercetools merged commit e2cfde1 into main Oct 31, 2023
3 checks passed
@dario-commercetools dario-commercetools deleted the dario/IM-571-add-mc-app-to-connect-starter-kit branch October 31, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants