Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maxAckDeadline in GCP pub/sub puller #141

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix maxAckDeadline in GCP pub/sub puller #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gcp/pubsub/src/main/scala/com/commercetools/queue/gcp/pubsub/PubSubPuller.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ private class PubSubPuller[F[_], T](
deserializer: Deserializer[T])
extends UnsealedQueuePuller[F, T] {

private val maxAckDeadlineSeconds = 600

private def callContext(waitingTime: FiniteDuration): ApiCallContext =
GrpcCallContext
.createDefault()
Expand Down Expand Up @@ -87,7 +89,8 @@ private class PubSubPuller[F[_], T](
.newBuilder()
.addAckIds(msg.getAckId())
.setSubscription(subscriptionName.toString())
.setAckDeadlineSeconds(time.Duration.between(now, until).getSeconds().toInt)
.setAckDeadlineSeconds(
Math.min(time.Duration.between(now, until).getSeconds().toInt, maxAckDeadlineSeconds))
.build()))).as(None)
case _ => F.pure(Some(msg))
}
Expand Down
Loading