[ISSUE-59] Adding the possibility of pass a custom prefix for Google PubSub #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianLentinoCT
force-pushed
the
feature/pubsub-subscription-prefix
branch
from
984acdf to
8d82df0
Compare
AL333Z
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Thanks @KristianLentinoCT for picking this up.
I left two minor comments, you will also need to fix the pipeline due to mima exceptions (the plugin if too strict, we know...).
The error messages will guide you on how to fix that, just reach out if you need help.
gcp/pubsub/src/main/scala/com/commercetools/queue/gcp/pubsub/PubSubAdministration.scala
Outdated
Show resolved
Hide resolved
gcp/pubsub/src/main/scala/com/commercetools/queue/gcp/pubsub/PubSubConfig.scala
Outdated
Show resolved
Hide resolved
KristianLentinoCT
force-pushed
the
feature/pubsub-subscription-prefix
branch
2 times, most recently
from
878ae28 to
c786c70
Compare
KristianLentinoCT
force-pushed
the
feature/pubsub-subscription-prefix
branch
2 times, most recently
from
5b93fba to
4196609
Compare
KristianLentinoCT
force-pushed
the
feature/pubsub-subscription-prefix
branch
from
4196609 to
f34e140
Compare
KristianLentinoCT
force-pushed
the
feature/pubsub-subscription-prefix
branch
from
d667bda to
ac2933d
Compare
satabin
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like requested on this issue I'm here to propose a way to let the user customize the prefix for Google PubSub subscriptions, while keeping the default value as it is inside the companion object of the new
PubSubConfigcase class.Let me know your thoughts!