Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AwsSessionCredentials to support aws oidc #91

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Use AwsSessionCredentials to support aws oidc #91

merged 5 commits into from
Nov 7, 2024

Conversation

r-tomassetti
Copy link
Contributor

@r-tomassetti r-tomassetti commented Oct 23, 2024 •
edited
Loading

In this PR I:

  • introduced AwsSessionCredentials to support oidc.
  • adjust and relax some assertions to make sqs tests pass:
    • the primary issue concerns retrieving message batches from SQS. While the only configurable parameter for SQS is maxNumberOfMessages, setting this parameter does not guarantee that all requested messages will be returned, even if the queue contains more than the specified maxNumberOfMessages.
  • decided to return List[MessageId] on ackAll nackAll, as it is more convenient for the user.
    • ackAll returns the list of unacked messages.
    • nackAll returns the list of messages for which the nack failed.

@AL333Z
Copy link
Member

AL333Z commented Oct 23, 2024

Looks good to me. 🎖️ 🏅 🥇

Can you please add a README with the instructions on how to run this from a local machine? something like this one or this other one.

@r-tomassetti r-tomassetti marked this pull request as draft October 23, 2024 12:33
@r-tomassetti r-tomassetti force-pushed the BEC-342-add-session-credentials-for-oidc branch from 6821961 to 38bd12b Compare October 29, 2024 11:41
@r-tomassetti r-tomassetti marked this pull request as ready for review November 5, 2024 10:34
@r-tomassetti r-tomassetti marked this pull request as draft November 5, 2024 10:34
@r-tomassetti r-tomassetti marked this pull request as ready for review November 5, 2024 13:18
@r-tomassetti r-tomassetti merged commit 7826f9b into main Nov 7, 2024
10 checks passed
@r-tomassetti r-tomassetti deleted the BEC-342-add-session-credentials-for-oidc branch November 7, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satabin satabin satabin approved these changes

@AL333Z AL333Z AL333Z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-tomassetti @AL333Z @satabin