Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: TypeScript support in Custom Applications and release v21.8 #2624

Merged
merged 13 commits into from
Jul 1, 2022
Merged

docs: TypeScript support in Custom Applications and release v21.8 #2624

merged 13 commits into from
Jul 1, 2022

Conversation

kark
Copy link
Contributor

@kark kark commented May 24, 2022 •
edited by emmenko
Loading

Ref #1668

The aim of this PR was to document TypeScript support in Custom Applications.

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: d9de292

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Preview May 24, 2022 08:35 Destroyed
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022 •
edited
Loading

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-nmzt4wdcc-commercetools.vercel.app
https://appkit-sha-a6bfd1eb01d8427aaa708f0f2690eb0767c4343e.commercetools.vercel.app
https://appkit-pr-2624.commercetools.vercel.app

Built with commit d9de292.
This pull request is being automatically deployed with vercel-action

@github-actions github-actions bot temporarily deployed to Preview May 24, 2022 14:10 Destroyed
@github-actions github-actions bot temporarily deployed to Preview May 25, 2022 08:56 Destroyed
@emmenko emmenko marked this pull request as draft May 27, 2022 09:20
@emmenko emmenko mentioned this pull request Jun 3, 2022
Open
10 tasks
@kark kark force-pushed the kk-typescript-docs branch from bf0fa78 to 5530014 Compare June 7, 2022 14:27
@github-actions github-actions bot temporarily deployed to Preview June 7, 2022 14:32 Destroyed
@kark kark force-pushed the kk-typescript-docs branch from 5530014 to 07b0be7 Compare June 21, 2022 12:21
@emmenko emmenko force-pushed the kk-typescript-docs branch from 07b0be7 to e59abba Compare June 29, 2022 15:54
@emmenko emmenko marked this pull request as ready for review June 29, 2022 15:58
@emmenko emmenko changed the title docs: TypeScript support in Custom Applications docs: TypeScript support in Custom Applications and release v21.8 Jun 29, 2022
@emmenko emmenko requested review from a team June 30, 2022 06:52
CarlosCortizasCT
CarlosCortizasCT reviewed Jun 30, 2022
View reviewed changes
website/src/releases/2022-07/release-v21.8.mdx
@@ -0,0 +1,48 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

CarlosCortizasCT
CarlosCortizasCT reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💪

I just left a couple of suggestion to maybe consider.

@emmenko emmenko force-pushed the kk-typescript-docs branch from c13fd06 to 785d879 Compare June 30, 2022 07:53
CarlosCortizasCT
CarlosCortizasCT approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@adinakleine
Copy link
Contributor

@kark When would you like to publish the docs? Just asking to see who can take over the review in the tech-writers team. 🙌

@emmenko
Copy link
Member

emmenko commented Jun 30, 2022

@adinakleine As soon as possible, as it's blocking the release 😇

Thanks 🙏

@industrian
Copy link
Contributor

@adinakleine As soon as possible, as it's blocking the release 😇

Thanks 🙏

I'll review it now.

industrian
industrian approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@industrian industrian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some suggestions to improve readability, but it LGTM.

Also, I'm not sure when you want the release note to go live, but its current date is 2022-07-04

website/src/content/development/index.mdx Outdated Show resolved Hide resolved
website/src/content/api-reference/commercetools-frontend-application-shell-connectors.mdx Outdated Show resolved Hide resolved
website/src/releases/2022-07/release-v21.8.mdx Outdated Show resolved Hide resolved
website/src/content/getting-started.mdx Outdated Show resolved Hide resolved
website/src/content/development/adding-typescript.mdx Outdated Show resolved Hide resolved
website/src/content/development/adding-typescript.mdx Outdated Show resolved Hide resolved
website/src/content/development/adding-typescript.mdx Outdated Show resolved Hide resolved
website/src/content/development/adding-typescript.mdx Outdated Show resolved Hide resolved
website/src/content/development/adding-typescript.mdx Outdated Show resolved Hide resolved
website/src/content/development/adding-typescript.mdx Outdated Show resolved Hide resolved
@emmenko
Copy link
Member

emmenko commented Jun 30, 2022

@industrian Thanks Stephen, I'll integrate the feedback 🙌

@emmenko emmenko force-pushed the kk-typescript-docs branch from b760487 to 069c038 Compare June 30, 2022 15:04
@emmenko emmenko force-pushed the kk-typescript-docs branch from 069c038 to f420988 Compare June 30, 2022 16:26
@emmenko emmenko force-pushed the kk-typescript-docs branch from f420988 to ead5494 Compare July 1, 2022 10:28
@emmenko emmenko enabled auto-merge (squash) July 1, 2022 10:36
@emmenko emmenko merged commit 363a624 into main Jul 1, 2022
@emmenko emmenko deleted the kk-typescript-docs branch July 1, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@industrian industrian industrian approved these changes

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

@Rhotimee Rhotimee Rhotimee approved these changes

@emmenko emmenko emmenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kark @adinakleine @emmenko @industrian @Rhotimee @CarlosCortizasCT