Introduce MongoProvidedFormat to skip generating MongoFormatters. Now… #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the skipping can also handle types with parameters.
benko-balog
commented
Oct 18, 2023
| subtypes.partition(mongoFormatExists(c)) | ||
| val singleParamTypes = subtypesWithFormatter.filter(_.asType.typeParams.length == 1) | ||
|
|
||
| val idents = Ident(symbol.name) :: (subtypes -- singleParamTypes).map { s => |
There was a problem hiding this comment.
We generate custom TypeSelectors for types with type parameters, so we remove them from this list. (The idents list will be the type parameter list of the mongoTypeSwitch method)
yanns
approved these changes
Oct 18, 2023
benko-balog
commented
Oct 18, 2023
| @@ -75,13 +75,13 @@ class SumTypesDerivingSpec extends AnyWordSpec with Matchers { | |||
| check(Color9.format, Color9.Custom("2356"), dbObj("type" -> "Custom", "rgb" -> "2356")) | |||
| } | |||
|
|
|||
| "Formatters could be overridden for objects" in { | |||
| "allow for providing custom instances for objects" in { | |||
There was a problem hiding this comment.
Change these so they with the Serializing sum types must ... wording
clemniem
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the skipping can also handle types with parameters.