forked from wayfair-incubator/telefonistka
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD 683 - Custom Commit Status URL #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzdann
force-pushed
the
SD-683
branch
2 times, most recently
from
October 21, 2024 13:24
03d4551
to
359a04b
Compare
This will be used for CUSTOM_COMMIT_STATUS_URL_TEMPLATE_PATH
yzdann
commented
Oct 21, 2024
@@ -0,0 +1 @@ | |||
{{ $calculated_time := .CommitTime.Add -600000000000 }}https://custom-url.com?time={{.CommitTime.UnixMilli}}&calculated_time={{$calculated_time.UnixMilli}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit more complicated calculations that we might use:
.CommitTime.Add -600000000000
is equal to:
CommitTime.Add(-10*time.Minute).UnixMilli()
hnnsgstfssn
previously approved these changes
Oct 22, 2024
hnnsgstfssn
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Considerations:
CUSTOM_COMMIT_STATUS_URL_TEMPLATE_PATH
: the current implementation is more toward using env variable to flags to keep focus on the implementation of this feature we don't do thatcommitStatusTargetURL
instead of loading it in application startup: the current code doesn't have the flexibility to read the env on start-up and expose as config it to the rest of the application. To changethat we need to change a couple of functions signature and it goes out of scope for this PR. see here
Read this PR commit by commit, to understand the changes:
Feature:
Extra Adjustments:
This will be used for CUSTOM_COMMIT_STATUS_URL_TEMPLATE_PATH
Type of Change
Checklist