Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sd 854 parallelize fetching of argocd diff in telefonistka #43

Merged
merged 13 commits into from
Dec 5, 2024
Merged

Sd 854 parallelize fetching of argocd diff in telefonistka #43

merged 13 commits into from
Dec 5, 2024

Conversation

ashvarts
Copy link

@ashvarts ashvarts commented Dec 3, 2024

Description

This pull request parallelizes the fetching of argocd diffs in telefonistka.

For testing, I had to make argoCdClients a global inside of the argocd package. This is so that it could be overwritten during testing. As a result, InitArgoClients() is called inside the handler to initialize the argocd clients, instead of being called from within the functions needing the client.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ashvarts ashvarts force-pushed the sd-854-parallelize-fetching-of-argocd-diff-in-telefonistka branch 2 times, most recently from f431bf8 to e83c23b Compare December 4, 2024 02:26
@ashvarts ashvarts force-pushed the sd-854-parallelize-fetching-of-argocd-diff-in-telefonistka branch from e83c23b to 762a1a8 Compare December 4, 2024 02:29
hnnsgstfssn
hnnsgstfssn reviewed Dec 4, 2024
View reviewed changes
Copy link

@hnnsgstfssn hnnsgstfssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Added some initial comments for consideration.

internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd_test.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd_test.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd_test.go Show resolved Hide resolved
Oded-B
Oded-B reviewed Dec 4, 2024
View reviewed changes
cmd/telefonistka/server.go Outdated Show resolved Hide resolved
hnnsgstfssn
hnnsgstfssn reviewed Dec 4, 2024
View reviewed changes
Copy link

@hnnsgstfssn hnnsgstfssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still global. I added a few code suggestions of what I meant by moving it up one level to the caller and creating an isolated clients struct in the test. Hopefully that makes sense.

internal/pkg/githubapi/github.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd_test.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd_test.go Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd_test.go Show resolved Hide resolved
ashvarts and others added 7 commits December 4, 2024 15:16
jared-logan-patrick-ct
jared-logan-patrick-ct previously approved these changes Dec 4, 2024
View reviewed changes
Copy link

@jared-logan-patrick-ct jared-logan-patrick-ct left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint errors needs resolving, but otherwise LGTM

hnnsgstfssn
hnnsgstfssn requested changes Dec 4, 2024
View reviewed changes
Copy link

@hnnsgstfssn hnnsgstfssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With dropping the last remaining err check left over looks good to me.

internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd_test.go Show resolved Hide resolved
@ashvarts ashvarts requested a review from hnnsgstfssn December 4, 2024 21:50
hnnsgstfssn
hnnsgstfssn previously approved these changes Dec 4, 2024
View reviewed changes
@ashvarts ashvarts force-pushed the sd-854-parallelize-fetching-of-argocd-diff-in-telefonistka branch from d1a00e5 to 847c5fc Compare December 5, 2024 15:24
@ashvarts ashvarts merged commit a77da6a into main Dec 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnnsgstfssn hnnsgstfssn hnnsgstfssn approved these changes

@jared-logan-patrick-ct jared-logan-patrick-ct jared-logan-patrick-ct left review comments

@Freyert Freyert Awaiting requested review from Freyert Freyert was automatically assigned from commercetools/special-delivery

@sunchill06 sunchill06 Awaiting requested review from sunchill06 sunchill06 was automatically assigned from commercetools/special-delivery

@Oded-B Oded-B Awaiting requested review from Oded-B

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashvarts @hnnsgstfssn @Oded-B @jared-logan-patrick-ct