refactor(custom-views): minor improvements

commercetools · Oct 18, 2023 · fb48612 · fb48612
1 parent 39462a7
commit fb48612
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 37 deletions.
diff --git a/models/custom-view/src/custom-view/constants.ts b/models/custom-view/src/custom-view/constants.ts
@@ -0,0 +1,10 @@
+export const defaultLocators = [
+  'products.product_details.general',
+  'products.product_variant_details.general',
+  'categories.category_details.external_search',
+  'customers.customer_addresses.edit_address',
+  'orders.order_details.custom_field',
+  'standalone_prices.standalone_price_details',
+  'discounts.product_discount_details.custom_fields',
+  'operations.import_log_details',
+];
diff --git a/models/custom-view/src/custom-view/generator.ts b/models/custom-view/src/custom-view/generator.ts
@@ -3,8 +3,8 @@ import { fake, Generator } from '@commercetools-test-data/core';
 import { createRelatedDates } from '@commercetools-test-data/utils';
 import * as CustomViewPermission from '../custom-view-permission';
 import * as CustomViewTypeSettingsForCustomPanel from '../custom-view-type-settings-for-custom-panel';
+import { defaultLocators } from './constants';
 import { TCustomView } from './types';
-import { defaultLocators } from './utils';
 
 const [getOlderDate, getNewerDate] = createRelatedDates();
 
@@ -19,7 +19,7 @@ const generator = Generator<TCustomView>({
     locators: fake((f) =>
       f.helpers.arrayElements(defaultLocators, {
         min: 1,
-        max: defaultLocators.length,
+        max: 4,
       })
     ),
     permissions: fake(() => [

diff --git a/models/custom-view/src/custom-view/utils.ts b/models/custom-view/src/custom-view/utils.ts