Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-data): unstub shims in goodstore data #386

Merged
merged 3 commits into from
Oct 2, 2023
Merged

chore(test-data): unstub shims in goodstore data #386

merged 3 commits into from
Oct 2, 2023

Conversation

jaikamat
Copy link
Contributor

@jaikamat jaikamat commented Oct 2, 2023

Summary

This PR gets rid of shims we had previously used in goodstore data presets.

@jaikamat jaikamat self-assigned this Oct 2, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

🦋 Changeset detected

Latest commit: 2eccde1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@commercetools-test-data/product-discount Patch
@commercetools-test-data/cart-discount Patch
@commercetools-test-data/discount-code Patch
@commercetools-test-data/order Patch
@commercetools-test-data/cart Patch
@commercetools-test-data/core Patch
@commercetools-test-data/business-unit Patch
@commercetools-test-data/category Patch
@commercetools-test-data/channel Patch
@commercetools-test-data/commons Patch
@commercetools-test-data/customer-group Patch
@commercetools-test-data/customer Patch
@commercetools-test-data/inventory-entry Patch
@commercetools-test-data/payment Patch
@commercetools-test-data/product-selection Patch
@commercetools-test-data/product-type Patch
@commercetools-test-data/product Patch
@commercetools-test-data/review Patch
@commercetools-test-data/shipping-method Patch
@commercetools-test-data/store Patch
@commercetools-test-data/tax-category Patch
@commercetools-test-data/zone Patch
@commercetools-test-data/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jaikamat jaikamat marked this pull request as draft October 2, 2023 16:32
@jaikamat jaikamat marked this pull request as ready for review October 2, 2023 16:54
Copy link
Contributor

@stephsprinkle stephsprinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need a changeset!

@jaikamat jaikamat merged commit aef6443 into main Oct 2, 2023
@jaikamat jaikamat deleted the FCT-532 branch October 2, 2023 18:36
@ct-changesets ct-changesets bot mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants